Implement tobytes for CuPy arrays
#2617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakirkham
force-pushed
the
add_tobytes
branch
6 times, most recently
from
882cf73 to
c369dbb
Compare
Member
|
Thank you for the PR! |
Collaborator
|
Successfully created a job for commit c369dbb: |
jakirkham
force-pushed
the
add_tobytes
branch
from
c369dbb to
5ca3dec
Compare
Makes a simple implementation of `tobytes` for CuPy arrays, which converts the data back into a NumPy array and let's NumPy do the heavy lifting.
jakirkham
force-pushed
the
add_tobytes
branch
from
5ca3dec to
dceca04
Compare
asi1024
reviewed
Nov 8, 2019
|
|
||
|
|
||
| @testing.parameterize( | ||
| {'shape': (1,)}, |
Member
Author
There was a problem hiding this comment.
Because trying to do prod of () wasn't working. Didn't realize you had a utility for shaped_arange though. So could give it another try.
Member
Author
There was a problem hiding this comment.
Have added () to the line before. Let's see how it goes 🙂
asi1024
reviewed
Nov 8, 2019
Co-Authored-By: Akifumi Imanishi <[email protected]>
Member
|
Jenkins CI test (for commit c369dbb, target branch master) failed with status FAILURE. |
Member
Author
|
Would it be possible to nudge Jenkins again? Think it is reporting for an old commit here. |
Member
|
Jenkins, test this please. |
Collaborator
|
Successfully created a job for commit 10c6c00: |
Member
|
Jenkins CI test (for commit 10c6c00, target branch master) succeeded! |
Member
|
LGTM. Thank you for the PR! |
Member
Author
|
Thanks for the review! 😀 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes a simple implementation of
tobytesfor CuPy arrays, which converts the data back into a NumPy array and let's NumPy do the heavy lifting.