all: use reflect.TypeAssert in three more places

mvdan · mvdan · commit 58cbd0c3fa8d · 2026-02-16T13:31:20.000Z
Others still use reflect.Value.Interface, but these are the ones that map to reflect.TypeAssert directly. Signed-off-by: Daniel Martí <mvdan@mvdan.cc> Change-Id: I7ac2bc7b9e1b689e21e4b68331f26fac74bf2784 Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1231001 TryBot-Result: CUEcueckoo <cueckoo@cuelang.org> Unity-Result: CUE porcuepine <cue.porcuepine@gmail.com> Reviewed-by: Roger Peppe <rogpeppe@gmail.com>
diff --git a/cue/decode.go b/cue/decode.go
@@ -385,7 +385,8 @@ func (d *decoder) convertMap(x reflect.Value, v Value) {
 		kt := t.Key()
 		if reflect.PointerTo(kt).Implements(textUnmarshalerType) {
 			kv = reflect.New(kt)
-			err := kv.Interface().(encoding.TextUnmarshaler).UnmarshalText([]byte(key))
+			u, _ := reflect.TypeAssert[encoding.TextUnmarshaler](kv)
+			err := u.UnmarshalText([]byte(key))
 			d.addErr(err)
 			kv = kv.Elem()
 		} else {
diff --git a/internal/astinternal/debug.go b/internal/astinternal/debug.go
@@ -104,7 +104,7 @@ func (d *debugPrinter) value0(v reflect.Value, impliedType reflect.Type) {
 			return
 		}
 		if k == reflect.Pointer {
-			if n, ok := v.Interface().(ast.Node); ok {
+			if n, ok := reflect.TypeAssert[ast.Node](v); ok {
 				ptrVal = v.Pointer()
 				if id, ok := d.nodeRefs[n]; ok {
 					refName = refIDToName(id)
@@ -259,8 +259,7 @@ func (d *debugPrinter) structFields(v reflect.Value) (anyElems bool) {
 			d.truncate(elemStart)
 		}
 	}
-	val := v.Addr().Interface()
-	if val, ok := val.(ast.Node); ok {
+	if val, ok := reflect.TypeAssert[ast.Node](v.Addr()); ok {
 		// Comments attached to a node aren't a regular field, but are still useful.
 		// The majority of nodes won't have comments, so skip them when empty.
 		if comments := ast.Comments(val); len(comments) > 0 {

Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,7 @@ func (d *debugPrinter) value0(v reflect.Value, impliedType reflect.Type) {`
`104`	`104`	`return`
`105`	`105`	`}`
`106`	`106`	`if k == reflect.Pointer {`
`107`		`- if n, ok := v.Interface().(ast.Node); ok {`
	`107`	`+ if n, ok := reflect.TypeAssert[ast.Node](v); ok {`
`108`	`108`	`ptrVal = v.Pointer()`
`109`	`109`	`if id, ok := d.nodeRefs[n]; ok {`
`110`	`110`	`refName = refIDToName(id)`
`@@ -259,8 +259,7 @@ func (d *debugPrinter) structFields(v reflect.Value) (anyElems bool) {`
`259`	`259`	`d.truncate(elemStart)`
`260`	`260`	`}`
`261`	`261`	`}`
`262`		`- val := v.Addr().Interface()`
`263`		`- if val, ok := val.(ast.Node); ok {`
	`262`	`+ if val, ok := reflect.TypeAssert[ast.Node](v.Addr()); ok {`
`264`	`263`	`// Comments attached to a node aren't a regular field, but are still useful.`
`265`	`264`	`// The majority of nodes won't have comments, so skip them when empty.`
`266`	`265`	`if comments := ast.Comments(val); len(comments) > 0 {`