Add int64 support#331
Conversation
fixes cube2222#330 Signed-off-by: Thomas Jungblut <[email protected]>
|
Hey @tjungblu, alive and well! Just didn't have time for OctoSQL for a while now. Since you're hitting this issue, are you on a 32-bit system? My assumption with OctoSQL was mostly building for 64-bit systems, where int would be 64-bit anyways. I have fairly intentionally avoided different bit type variants in the octosql type system to avoid the complexity. What would you think, instead, about changing all the places that are problematic where simple |
|
You're correct, int is 64 bits on a 64 bit system: On a raspberry pi armv7l, which is 32 bit it's unfortunately not: I realize there's no official 32 bit build of octosql, but it's somewhat inconvenient you have to be aware of your processor to get the correct result 🙄
let me try! I'll send you another follow-up PR, we can decide what to make of it. Thanks @cube2222 :) |
fixes #330
@cube2222 I hope you're still alive. I'm seriously bitten by the lack of int64 for byte sizes and other large aggregations, so it would be incredible if we could add this one way or the other.