fix(schema-compiler): prevent member name collection from impacting joins#9942
Closed
Spark-NF wants to merge 5 commits intocube-js:masterfrom
Spark-NF:master
Closed
fix(schema-compiler): prevent member name collection from impacting joins#9942Spark-NF wants to merge 5 commits intocube-js:masterfrom Spark-NF:master
Spark-NF wants to merge 5 commits intocube-js:masterfrom
Spark-NF:master
Conversation
github-actions
bot
added
the
pr:community
Author
|
I'm not quite sure why the tests are failing, they seem unrelated to the change? 🤔 |
Contributor
|
@Spark-NF, thanks for trying to fix this. But well... unit tests are failing. You can try to run it locally within the schema-compiler package and examine the output with/without your changes. I'm pretty sure they are related. For example some sort of internal caches. |
Author
|
@KSDaemon indeed, seems like I was compiling the wrong compiler in the test I added. I guess I got confused by the CI output, downloading the CI logs and re-running the tests locally made it clear. |
github-actions
bot
added
the
javascript
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check List
Issue Reference this PR resolves
#9941