Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9500 +/- ##
===========================================
- Coverage 83.86% 59.59% -24.27%
===========================================
Files 230 153 -77
Lines 83825 13130 -70695
Branches 0 2240 +2240
===========================================
- Hits 70297 7825 -62472
+ Misses 13528 4990 -8538
- Partials 0 315 +315
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
KSDaemon
force-pushed
the
feat/yaml-support-rollup-designer
branch
from
fde595a to
1067c03
Compare
…gner for YAML-based models
KSDaemon
force-pushed
the
feat/yaml-support-rollup-designer
branch
2 times, most recently
from
146bfb6 to
4d10e5c
Compare
KSDaemon
force-pushed
the
feat/yaml-support-rollup-designer
branch
from
4d10e5c to
042b561
Compare
ovr
approved these changes
Apr 25, 2025
marianore-muttdata
pushed a commit
to MuttData/cube
that referenced
this pull request
Jun 17, 2025
…gner for YAML-based models (cube-js#9500) * prepare schema converter for yaml * add yaml package * fix: do not write all files while you need only one * feat(schema-compiler): Support adding pre-aggregations in Rollup Designer for YAML-based models * process and write only one required file * add basic test for CubeSchemaConverter * test for yaml pre-agg gen * add note * more tests * rename test * fix tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings the missing piece of Rollup Designer: support for
yaml-based models! Now you can generate pre-aggregations and update your yaml schema files with ease!Fixes #5989.
Check List