install dynamic build dependencies, too#189
Closed
kdudka wants to merge 6 commits intocsutils:mainfrom
Closed
Conversation
Network availability should be controlled by `mock` directly based on its own configuration. Related: openscanhub/fedora-infra#69
They do not seem to be needed any more.
... to make the function easier to maintain
This is an emergency measure and modern releases of `mock` keep much more data that may become stale or broken than just the root cache.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
... with `--keep-going`
Use the `--calculate-build-dependencies` option of `mock` instead of the `--installdeps` option, which installs static build dependencies only. Fixes: csutils#188 Closes: csutils#189
siteshwar
approved these changes
Nov 6, 2024
Member
Author
|
@siteshwar Thanks for review! |
kdudka
added a commit
to kdudka/csmock
that referenced
this pull request
Nov 6, 2024
... to avoid recreating the buildroot from scratch on each invocation Fixes: csutils#189 Closes: csutils#190
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the
--calculate-build-dependenciesoption ofmockinstead of the--installdepsoption, which installs static build dependencies only.Fixes: #188