You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 5287505
Browse filesBrowse the repository at this point in the historyBrowse files
[refactor](be) Fix the clang-tidy findings on the StorageLayout read changes
### What problem does this PR solve?
Issue Number: None
Related PR: apache#68608
Problem Summary: Review follow-up. clang-tidy reports errors on lines this
branch changed, in test files the earlier tidy pass did not cover:
- The decimal12_t brace initializers in storage_layout_test and
row_cursor_test now name their fields
(modernize-use-designated-initializers).
- The V1 DATE page tests of plain_page_test and bitshuffle_page_test build
their page in a fixture helper, and decoding by batch and reading by row id
into a Nullable column are now separate tests. Each test checks one path,
and each body stays under the cognitive-complexity threshold.
- key_coder_test's test_ordering, whose body is unchanged from master and
whose signature line the rename touched, gets the NOLINTNEXTLINE that other
long test bodies in be/test use.
repack_to_column now tests for a Nullable destination with is_column_nullable,
as the column reader does. IColumn::is_nullable() is also true for a
ColumnConst over a Nullable, which the cast that follows would reject. A page
decoder is only ever handed a column the reader created, so nothing changes at
run time.
### Release note
None
### Check List (For Author)
- Test: Unit Test
- Run on this revision (ASAN build): 675 tests from 31 suites, the set run
for the rename, all pass; PlainPageTest (9) and BitShufflePageTest (15)
now hold the split V1 DATE tests.
- clang-format 16, build hygiene, clang-tidy on the six files this
commit touches: no finding on a line the branch changes.
- Behavior changed: No
- Does this need documentation: No
Co-Authored-By: Claude Opus 5.5 <[email protected]>
0 commit comments