Skip to content

Commit 183d73e

Browse files
authored
[fix](fe) Reject complex types as map keys (apache#69101)
### What problem does this PR solve? ``` sql "select map(named_struct('a', 1), 'v')" exception "MAP key type must be a primitive type" ```
1 parent a290247 commit 183d73e

3 files changed

Lines changed: 33 additions & 0 deletions

File tree

‎fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/CreateMap.java‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,10 @@ public void checkLegalityBeforeTypeCoercion() {
8888
for (int i = 0; i < arity(); i++) {
8989
DataType childType = getArgument(i).getDataType();
9090
boolean isKey = i % 2 == 0;
91+
if (isKey && childType.isComplexType()) {
92+
throw new AnalysisException(
93+
"MAP key type must be a primitive type but get " + childType.toSql());
94+
}
9195
if (childType.isJsonType()) {
9296
throw new AnalysisException("map does not support jsonb type");
9397
}

‎fe/fe-core/src/test/java/org/apache/doris/nereids/trees/expressions/functions/scalar/MapConstructionFunctionsTest.java‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,22 @@ public void testMapFromEntriesCanBeAnalyzed() {
126126
TinyIntType.INSTANCE, ArrayType.of(TinyIntType.INSTANCE));
127127
}
128128

129+
@Test
130+
public void testCreateMapRejectsComplexKey() {
131+
for (String sql : ImmutableList.of(
132+
"map(array(1, 2), 'v')",
133+
"map(named_struct('a', 1), 'v')",
134+
"map(map(1, 2), 'v')")) {
135+
AnalysisException complexKeyException = Assertions.assertThrows(
136+
AnalysisException.class, () -> analyze(sql));
137+
Assertions.assertTrue(complexKeyException.getMessage().contains(
138+
"MAP key type must be a primitive type"), complexKeyException::getMessage);
139+
}
140+
141+
Assertions.assertDoesNotThrow(() -> analyze("map('k', array(1, 2))"));
142+
Assertions.assertDoesNotThrow(() -> analyze("map(NULL, 100)"));
143+
}
144+
129145
@Test
130146
public void testMapFromEntriesPreservesIndependentPrecision() {
131147
DataType decimalKeyType = DecimalV3Type.createDecimalV3Type(38, 0);

‎regression-test/suites/nereids_function_p0/scalar_function/nereids_scalar_fn_map.groovy‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -335,6 +335,19 @@ suite("nereids_scalar_fn_map") {
335335
qt_sql "select map('postal_code', 10001, 'area_code', 10002, 'zip_plus_4', 10003)"
336336
qt_sql "select map('{\"zip\":10001}', '{\"city\":\"NY\"}', '{\"code\":10002}', '{\"state\":\"NY\"}')"
337337

338+
test {
339+
sql "select map(array(1, 2), 'v')"
340+
exception "MAP key type must be a primitive type"
341+
}
342+
test {
343+
sql "select map(named_struct('a', 1), 'v')"
344+
exception "MAP key type must be a primitive type"
345+
}
346+
test {
347+
sql "select map(map(1, 2), 'v')"
348+
exception "MAP key type must be a primitive type"
349+
}
350+
338351
sql """ drop table if exists fn_test_element_at_map_date """
339352
sql """
340353
create table fn_test_element_at_map_date (

0 commit comments

Comments
 (0)