Fix misc things then reindent#2
Merged
cstrahan merged 4 commits intocstrahan:hardening-fixfrom Apr 10, 2018
Merged
Conversation
Ericson2314
force-pushed
the
hardening-fix
branch
from
7ee63d5 to
ad7ae9b
Compare
Ericson2314
force-pushed
the
hardening-fix
branch
from
ad7ae9b to
4ad30f5
Compare
cstrahan
reviewed
Apr 10, 2018
| if (( "${#hardeningEnableMap[@]}" )); then | ||
| if (( "${NIX_DEBUG:-0}" >= 1 )); then | ||
| if (( "${#hardeningEnableMap[@]}" )); then | ||
| echo 'HARDENING: Is active (not completely disabled with "all" flag)' >&2; |
Owner
There was a problem hiding this comment.
@Ericson2314 Did you mean to drop the if (( "${NIX_DEBUG:-0}" >= 1 )) condition? We'll start getting a lot more noise in our builds, and I'd fear some builds failing due to the extra (unexpected) output.
Owner
There was a problem hiding this comment.
Oh wait, never mind. I see. This is tucked under a similar condition anyway. I wasn't following the diff closely enough. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The last commit reindents but the others are more meaningful.
Things done
Please check what applies. Note that these are not hard requirements but mereley serve as information for reviewers.
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)