Skip to content

Commit 6c41da8

Browse files
fix(fullsend-ai#1512)!: declare profile credentials for OpenShell 0.1
OpenShell 0.1.x validates every provider credential against the profile's declared credentials: list, and it accepts a provider with no credentials. The _NOOP_* empty-map placeholders that papered over NVIDIA/OpenShell#1978 are now rejected as undeclared. - Declare GH_TOKEN / GITLAB_TOKEN / JIRA_TOKEN on the six token-bearing profiles, matching fullsend's fullsend-openai shape without auth_style, header_name, or refresh. - Drop the credentials: block from vertex-ai, gitleaks, package-registries, and github-artifacts. - Add a unit test that locks the declarations in. .github/workflows/functional-tests.yml still writes gateway schema v1; a maintainer must switch it to schema v2 on this PR (workflow permissions). Lands with fullsend-ai/fullsend#7233; no 0.0.x compatibility is kept. Note: pre-commit could not fetch hook repos (HTTP 403). Hooks were run directly at the pinned revs (check-yaml, end-of-file-fixer, trailing-whitespace, detect-private-key, check-added-large-files, check-merge-conflict, mixed-line-ending, shellcheck, gitleaks) and passed. BREAKING CHANGE: Credential-less providers no longer send a dummy credential. OpenShell 0.0.x still refuses an empty credential map, so this repo requires OpenShell 0.1.1. Closes fullsend-ai#1512
1 parent fa6f19d commit 6c41da8

12 files changed

Lines changed: 192 additions & 8 deletions

‎Makefile‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@ script-test:
7474
$(call run-timed,bash scripts/pre-code-jira-test.sh)
7575
$(call run-timed,bash scripts/harness-jira-test.sh)
7676
$(call run-timed,bash scripts/sandbox-credential-boundary-test.sh)
77+
$(call run-timed,bash scripts/provider-credentials-test.sh)
7778
$(call run-timed,bash scripts/signoff-strip-test.sh)
7879
$(call run-timed,bash scripts/post-code-test.sh)
7980
$(call run-timed,bash scripts/pre-review-test.sh)

‎profiles/fullsend-github-code.yaml‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,11 @@ id: fullsend-github-code
55
display_name: Fullsend GitHub (code agents)
66
description: Read-only GitHub API and Git operations for code and fix agents
77
category: source_control
8+
credentials:
9+
- name: api_token
10+
description: GitHub token
11+
env_vars: [GH_TOKEN]
12+
required: true
813
endpoints:
914
- host: api.github.com
1015
port: 443

‎profiles/fullsend-github-ro.yaml‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,11 @@ id: fullsend-github-ro
55
display_name: Fullsend GitHub (read-only)
66
description: Read-only GitHub API access for fullsend agents
77
category: source_control
8+
credentials:
9+
- name: api_token
10+
description: GitHub token
11+
env_vars: [GH_TOKEN]
12+
required: true
813
endpoints:
914
- host: api.github.com
1015
port: 443

‎profiles/fullsend-gitlab-code.yaml‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,11 @@ id: fullsend-gitlab-code
55
display_name: Fullsend GitLab (code agents)
66
description: Read-only GitLab API and Git operations for code and fix agents
77
category: source_control
8+
credentials:
9+
- name: api_token
10+
description: GitLab token
11+
env_vars: [GITLAB_TOKEN]
12+
required: true
813
endpoints:
914
- host: gitlab.com
1015
port: 443

‎profiles/fullsend-gitlab-ro.yaml‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,11 @@ id: fullsend-gitlab-ro
55
display_name: Fullsend GitLab (read-only)
66
description: Read-only GitLab API access for fullsend agents
77
category: source_control
8+
credentials:
9+
- name: api_token
10+
description: GitLab token
11+
env_vars: [GITLAB_TOKEN]
12+
required: true
813
endpoints:
914
- host: gitlab.com
1015
port: 443

‎profiles/fullsend-gitlab-rw.yaml‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,11 @@ id: fullsend-gitlab-rw
66
display_name: Fullsend GitLab (read-write)
77
description: Read-write GitLab API access for fullsend agents
88
category: source_control
9+
credentials:
10+
- name: api_token
11+
description: GitLab token
12+
env_vars: [GITLAB_TOKEN]
13+
required: true
914
endpoints:
1015
- host: gitlab.com
1116
port: 443

‎profiles/fullsend-jira-ro.yaml‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,11 @@ id: fullsend-jira-ro
33
display_name: Fullsend Jira (read-only)
44
description: Read-only Jira Cloud API access for fullsend agents
55
category: data
6+
credentials:
7+
- name: api_token
8+
description: Jira API token
9+
env_vars: [JIRA_TOKEN]
10+
required: true
611
endpoints:
712
# Jira Cloud only (v1) — see design.md Decision 7.
813
- host: "*.atlassian.net"

‎providers/github-artifacts.yaml‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,3 @@
99
# reject the sandbox.
1010
name: github-artifacts
1111
type: fullsend-github-artifacts
12-
credentials:
13-
_NOOP_GITHUB_ARTIFACTS: ""

‎providers/gitleaks.yaml‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
11
---
22
name: gitleaks
33
type: fullsend-gitleaks
4-
credentials:
5-
_NOOP_GITLEAKS: ""

‎providers/package-registries.yaml‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
11
---
22
name: package-registries
33
type: fullsend-package-registries
4-
credentials:
5-
_NOOP_PACKAGE_REGISTRIES: ""

0 commit comments

Comments
 (0)