Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin bar highlights don't work on themes that support the wp_body_open filter #3

Closed
csalzano opened this issue Aug 19, 2021 · 2 comments
Closed

Admin bar highlights don't work on themes that support the wp_body_open filter #3

csalzano opened this issue Aug 19, 2021 · 2 comments
Assignees
@csalzano
Labels
wontfix This will not be worked on

Comments

@csalzano
Copy link
Owner

csalzano commented Aug 19, 2021 •
edited
Loading

Did the gform_pre_render hook change and begin running later? Already using the latest hook to change the admin bar.
@csalzano csalzano self-assigned this Aug 19, 2021
@csalzano
Copy link
Owner Author

default-filters.php

Theme's that support the wp_body_open action will not be able to see this feature:

add_action( 'wp_body_open', 'wp_admin_bar_render', 0 );
add_action( 'wp_footer', 'wp_admin_bar_render', 1000 ); // Back-compat for themes not using `wp_body_open`.
add_action( 'in_admin_header', 'wp_admin_bar_render', 0 );

The admin bar can only be edited to highlight forms that have been loaded on the current page if it runs during the wp_footer hook.

@csalzano csalzano changed the title Admin bar highlights no longer working Admin bar highlights don't work on themes that support the wp_body_open filter Aug 19, 2021
@csalzano csalzano added the wontfix This will not be worked on label Aug 23, 2021
@csalzano
Copy link
Owner Author

Removed in 2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@csalzano csalzano

Labels
wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@csalzano