Enhancement: Add status field to projects table (default value: active)#5523
Merged
Enhancement: Add status field to projects table (default value: active)#5523
Conversation
pmedinar01
requested review from
diocas,
glpatcern,
jessegeens and
rawe0
as code owners
There was a problem hiding this comment.
Pull request overview
Adds a status column to the SQL-backed projects catalog so project records can carry a lifecycle/state indicator, and documents the change in the unreleased changelog.
Changes:
- Added
Statusfield toProjectGORM model with a DB default. - Fixed a typo in an existing struct field comment.
- Added an unreleased changelog entry for the new column.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/projects/manager/sql/sql.go | Extends the Project DB model with a Status column (and fixes a comment typo). |
| changelog/unreleased/project-status-field | Documents the schema enhancement for release notes. |
Comments suppressed due to low confidence (2)
pkg/projects/manager/sql/sql.go:76
- PR metadata says the new
statuscolumn should default to empty, but the model tag sets a DB default of'active'and the changelog also mentions'active'. Please align the implementation and documentation (either change the default in the GORM tag or update the PR title/changelog accordingly) to avoid an unintended schema default.
// Status of the project (e.g., active, pending creation, etc.)
Status string `gorm:"size:50;default:'active'"`
pkg/projects/manager/sql/sql.go:76
- The new
Statusfield introduces behavior (a DB-level default) but there’s no test asserting what value is persisted whenStatusis left unset/empty. Please add/extend an existing SQL manager test to create a project withoutStatusand verify the stored value matches the intended default.
Status string `gorm:"size:50;default:'active'"`
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pmedinar01
force-pushed
the
update_projects_table
branch
from
b51f769 to
6fbe8b0
Compare
jessegeens
requested changes
Mar 2, 2026
diocas
requested changes
Mar 2, 2026
Contributor
diocas
left a comment
diocas
left a comment
There was a problem hiding this comment.
As Jesse pointed out, we will need to query the DB for all projects in "creating" status, so that we go throught them and check if we can finish, right? So, maybe an index should be added.
Don't we also need to add the filtering logic in Reva to use it later in cernboxcop?
Contributor
That was going to be my next remark :) Additionally, do we want to filter on type "created" by default? Otherwise archived / pending_creation projects will also show up in your list of projects |
pmedinar01
force-pushed
the
update_projects_table
branch
from
b284d7c to
defcddb
Compare
…nable the other two types if specified
pmedinar01
force-pushed
the
update_projects_table
branch
from
f12e62d to
d08e213
Compare
pmedinar01
changed the title
jessegeens
reviewed
Mar 2, 2026
jessegeens
reviewed
Mar 2, 2026
jessegeens
reviewed
Mar 2, 2026
jessegeens
reviewed
Mar 2, 2026
jessegeens
requested changes
Mar 2, 2026
pmedinar01
force-pushed
the
update_projects_table
branch
from
d223510 to
d4fe4f4
Compare
jessegeens
reviewed
Mar 3, 2026
jessegeens
reviewed
Mar 3, 2026
jessegeens
reviewed
Mar 3, 2026
jessegeens
requested changes
Mar 3, 2026
jessegeens
reviewed
Mar 3, 2026
… of going from archived to active
jessegeens
previously approved these changes
Mar 3, 2026
jessegeens
approved these changes
Mar 3, 2026
diocas
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.