Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
jessegeens
force-pushed
the
refactor/cleanup-spaceslevel
branch
2 times, most recently
from
44f2ea6 to
5953992
Compare
jessegeens
force-pushed
the
refactor/cleanup-spaceslevel
branch
from
5953992 to
aa52852
Compare
jessegeens
force-pushed
the
refactor/cleanup-spaceslevel
branch
2 times, most recently
from
74505cd to
31fc491
Compare
jessegeens
force-pushed
the
refactor/cleanup-spaceslevel
branch
2 times, most recently
from
78250ab to
ae493e1
Compare
jessegeens
changed the title
…nd use space depth to determine when resources can be shared
jessegeens
force-pushed
the
refactor/cleanup-spaceslevel
branch
from
ae493e1 to
93e908c
Compare
glpatcern
previously approved these changes
Mar 2, 2026
glpatcern
reviewed
Mar 2, 2026
glpatcern
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
spacesLevelfunction, which contained hardcoded values for determining at what level a space starts. This is now configurable with thespace_depthparameter in the storage provider