Conversation
jessegeens
force-pushed
the
fix/ownerless-trashbin
branch
5 times, most recently
from
c108e29 to
159c76c
Compare
glpatcern
left a comment
glpatcern
left a comment
There was a problem hiding this comment.
All good to me except for a mini change:
jessegeens
force-pushed
the
fix/ownerless-trashbin
branch
from
159c76c to
a2c3242
Compare
| // We'll get the owner of the particular resource and impersonate them | ||
| // if we have access to it. | ||
| // user's own trashbin | ||
| if basePath == "/" { |
There was a problem hiding this comment.
Don't we have a separate way to detect projects? Not that this is a problem right now, but this prevents us from using folder navigation inside a trashbin in the future. Also, have the impression this was being handled differently in other parts of the code.
There was a problem hiding this comment.
I'm also not sure why we need this special case. If we're talking about a home trashbin, wouldn't we do the same as bellow and request as the owner?
There was a problem hiding this comment.
Don't we have a separate way to detect projects?
Yes, sure, but that's not the only case: you can also be working in someone else's home when a folder has been shared with you. So that wouldn't work here
There was a problem hiding this comment.
To me a proper way to detect project vs personal space going forward will be to look for this recycleid, as all projects will have it and none of the personal spaces will have it.
3 participants
Depends on #5474