Skip to content

OCM: Handle ROCrate#5452

Merged
glpatcern merged 9 commits intomasterfrom
handle-ro-crate
Jan 13, 2026
Merged

OCM: Handle ROCrate#5452
glpatcern merged 9 commits intomasterfrom
handle-ro-crate

Conversation

@rawe0
Copy link
Copy Markdown
Member

@rawe0 rawe0 commented Dec 19, 2025

This PR contains the following:

  • Adds functionality to store embedded shares (where the shared data is embedded in the share)
  • Adds filters to ListReceivedOCMShares call and adapts to the new fields SharedResourceType and RecipientType
  • Adds an endpoint to list embedded shares (using the previously mentioned filters)

@update-docs
Copy link
Copy Markdown

update-docs Bot commented Dec 19, 2025

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@rawe0 rawe0 changed the title Handle ro crate OCM: Handle ROCrate Dec 22, 2025
@rawe0 rawe0 force-pushed the handle-ro-crate branch 7 times, most recently from 88174ee to 0d1d842 Compare December 25, 2025 21:33
@rawe0 rawe0 marked this pull request as ready for review December 25, 2025 22:32
Copy link
Copy Markdown
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks generally good though there are some changes. I'm going to stack another PR on top of this one so please once you're back just add commits without overwriting the history ;-)

Comment thread internal/http/services/sciencemesh/embedded.go Outdated
Comment thread internal/http/services/wellknown/ocm.go Outdated
Comment thread internal/http/services/wellknown/ocm.go Outdated
Comment thread internal/http/services/wellknown/ocm.go Outdated
Comment thread internal/http/services/wellknown/ocm.go Outdated
@rawe0 rawe0 requested a review from glpatcern January 11, 2026 04:41
Comment thread pkg/ocm/share/utils.go Outdated
Comment thread changelog/unreleased/embedded-shares.md Outdated
@glpatcern glpatcern self-requested a review January 12, 2026 08:26
Copy link
Copy Markdown
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ready for merge. Will keep it on hold for now in case we need some urgent fix in Reva.

@glpatcern glpatcern merged commit 739bced into master Jan 13, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants