Fix event parser panic from insufficient topics (#789)#790
Merged
Conversation
Add two bounds checks to UnpackEventAndValues to prevent panic when processing events with insufficient topics: 1. Check Topics array is non-empty before accessing Topics[0] 2. Verify sufficient topics exist for indexed arguments before loop Both checks return nil to gracefully handle ABI resolution failures, maintaining consistency with existing error handling patterns. Fixes panic when vm.etch creates mismatched ABI/bytecode combinations. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes panic in event parsing when processing events with insufficient topics. This commonly occurs with
vm.etchcheatcode when compiled ABI doesn't match runtime bytecode.Changes
Added two bounds checks to
UnpackEventAndValuesincompilation/abiutils/solidity_events.go:Topics[0])Topics[i+1])Both checks return
nilon failure, maintaining consistency with existing error handling patterns in the codebase.Behavior
<unresolved(topics=[...], data=...)>for unresolvable eventsTesting
go test -v ./...)Fixes #789
🤖 Generated with Claude Code