chore: execute goimports to format the code#757
Closed
promalert wants to merge 1 commit intocrytic:masterfrom
Closed
chore: execute goimports to format the code#757promalert wants to merge 1 commit intocrytic:masterfrom
promalert wants to merge 1 commit intocrytic:masterfrom
Conversation
Signed-off-by: promalert <[email protected]>
promalert
requested review from
Xenomega,
anishnaik and
samalws-tob
as code owners
|
|
dguido
requested changes
Jan 20, 2026
Member
dguido
left a comment
dguido
left a comment
There was a problem hiding this comment.
The change is directionally correct - standardized imports are good practice. However, a few issues:
-
Incomplete application: This only fixes 20 files, but there are more files with non-standard import ordering. Consider running
goimports -w .on the entire codebase. -
CI enforcement missing: Without adding
goimportsto CI, the codebase will drift back to inconsistent formatting. Consider adding to the lint job:- name: Check imports run: | go install golang.org/x/tools/cmd/goimports@latest test -z "$(goimports -d .)"
-
PR type: The type is marked as "Documentation" but this is a formatting/style change.
Suggested next steps:
- Run
goimports -w .on the entire codebase - Add
goimportscheck to CI - Update PR description
dguido
added a commit
that referenced
this pull request
Jan 20, 2026
- Run goimports -w . on entire codebase to standardize import ordering - Add goimports check to CI lint job to prevent drift - Addresses review feedback on PR #757 Co-Authored-By: Claude Opus 4.5 <[email protected]>
Member
|
This PR has been superseded by #764 which:
Thank you @promalert for the original contribution! 🙏 |
dguido
added a commit
that referenced
this pull request
Jan 20, 2026
- Run goimports -w . on entire codebase to standardize import ordering - Add goimports check to CI lint job to prevent drift - Addresses review feedback on PR #757 Co-Authored-By: Claude Opus 4.5 <[email protected]>
dguido
added a commit
that referenced
this pull request
Jan 20, 2026
- Run goimports -w . on entire codebase to standardize import ordering - Add goimports check to CI lint job to prevent drift - Addresses review feedback on PR #757 Co-Authored-By: Claude Opus 4.5 <[email protected]>
Member
|
Closing in favor of #764 which addresses the review feedback. |
dguido
added a commit
that referenced
this pull request
Jan 20, 2026
- Run goimports -w . on entire codebase to standardize import ordering - Add goimports check to CI lint job to prevent drift - Addresses review feedback on PR #757 Co-Authored-By: Claude Opus 4.5 <[email protected]>
dguido
added a commit
that referenced
this pull request
Jan 20, 2026
- Run goimports -w . on entire codebase to standardize import ordering - Add goimports check to CI lint job to prevent drift - Addresses review feedback on PR #757 Co-authored-by: Claude Opus 4.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
execute goimports to format the code
Type of Change:
Testing
Additional Context
Outstanding TODOs