refactor: remove obsolete // +build tag#738
Merged
dguido merged 2 commits intocrytic:masterfrom Jan 20, 2026
Merged
Conversation
zjumathcode
requested review from
Xenomega,
anishnaik and
samalws-tob
as code owners
|
|
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
dguido
approved these changes
Jan 20, 2026
Member
dguido
left a comment
dguido
left a comment
There was a problem hiding this comment.
LGTM - correct removal of obsolete // +build syntax. The //go:build directive is already present and takes precedence.
Signed-off-by: zjumathcode <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
From Go 1.17, the preferred syntax for build constraints is
//go:build,which replaces the old
// +buildform. The old style is now considereddeprecated but still supported for backward compatibility.
This change removes the obsolete
// +build xxxline, keeping only themodern
//go:build xxxdirective.More info: golang/go#41184 and https://go.dev/doc/go1.17#build-lines
Design Doc / Proposal：
https://go.dev/design/draft-gobuild
Related Issues:
Type of Change:
Testing
Additional Context
Outstanding TODOs