Conversation
GetLogs() walks the `map[common.Hash][]*types.Log` and concatenates all of the events there. Then it picks the last one. However, the current tx hash is not necessarily the last one on the concatenation, which means that the event collected is probably not the desired one. This changes the code to store the current tx hash OnTxStart and then use it to query the specific logs for that transaction.
The transaction object doesn't have the "from" address as that is implied by the signature on a normal transaction. However, medusa does not sign transactions. To keep them distinguishable from each other, this stores the from address in one of the signature fields.
anishnaik
requested review from
Xenomega,
anishnaik and
bsamuels453
as code owners
anishnaik
approved these changes
Aug 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetLogs() walks the
map[common.Hash][]*types.Logand concatenates all of the events there. Then it picks the last one. However, the current tx hash is not necessarily the last one on the concatenation, which means that the event collected is probably not the desired one.This changes the code to store the current tx hash OnTxStart and then use it to query the specific logs for that transaction.
Additionally, the transaction object doesn't have the "from" address as that is implied by the signature on a normal transaction. However, medusa does not sign transactions, which causes transaction hashes to collision if they only differ in the sender address. To keep them distinguishable from each other, this stores the from address in one of the signature fields.