Skip to content

Fix ordering when predeploys and autolinking are both used#658

Merged
anishnaik merged 1 commit intomasterfrom
predeploy-autolink-ordering
Aug 8, 2025
Merged

Fix ordering when predeploys and autolinking are both used#658
anishnaik merged 1 commit intomasterfrom
predeploy-autolink-ordering

Conversation

@samalws-tob
Copy link
Copy Markdown
Contributor

@samalws-tob samalws-tob commented Jul 31, 2025

  • Make GetDeploymentOrder aware of predeploys and prioritize them first
  • Remove code in chainSetupFromCompilations that prioritizes predeploys, since GetDeploymentOrder already did that
  • Some cleanup here and there, e.g. made GetDeploymentOrder use a priority queue using container/heap from standard library

Resolves #655

@samalws-tob samalws-tob force-pushed the predeploy-autolink-ordering branch from 4cf7419 to 0d20892 Compare July 31, 2025 17:59
@anishnaik anishnaik merged commit 116a4d1 into master Aug 8, 2025
25 of 36 checks passed
@anishnaik anishnaik deleted the predeploy-autolink-ordering branch August 8, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automatic Library Linking causes crash when used in combination with predeployedContracts

2 participants