Add Configurable Verbosity Levels for Execution Traces#601
Merged
Add Configurable Verbosity Levels for Execution Traces#601
Conversation
Collaborator
|
Closes #204 |
anishnaik
requested changes
Mar 24, 2025
Collaborator
There was a problem hiding this comment.
The core functionality looks great! My only gripe is the complexity of the smart contract test case. A simpler test is always better as long as it covers the same code paths as the test case you have written (which I believe it can).
Additionally, can you make sure that the feature works as expected through the CLI? Thus, build the binary and run medusa fuzz -v, medusa fuzz -vv, and medusa fuzz -vvv on the same piece of test code. Maybe a small stress test of medusa fuzz -verbosity -v would be good to see how that would work? You can run these commands on the same contract that you wrote the unit test for.
Finally, one of the linters is complaining so make sure to fix that as well.
fuzzing/testdata/contracts/execution_tracing/verbosity_levels.sol
Outdated
Show resolved
Hide resolved
fuzzing/testdata/contracts/execution_tracing/verbosity_levels.sol
Outdated
Show resolved
Hide resolved
…nto dev/add-verbosity-levels
anishnaik
approved these changes
Mar 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces three distinct verbosity levels for execution traces in Medusa, giving users more control over the level of detail shown in trace outputs. This is especially beneficial for complex systems with multiple call frames, where the current trace output can be overwhelming.
Changes