Basic startPrank/stopPrank cheat code support#594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #446 . It introduces the basic variant of
startPrankandstopPrankcheat codes (msg.sendersupport only)Expected behavior:
startPrankdoes pranking only one call level deeper than it was initiated from. Thus, the scopestartPrankis called in is not affected, only direct sub-calls.stopPrankcan be called without astartPrank, with no issue/revert.startPrankcan be called, overriding the previousstartPrank(it does not act like a stack).startPrankwas not applied at least once. This doesn't seem important to us to enforce(?)startPrankin a reverted scope should inherently have no effect (not be pranking anymore).Outstanding TODOs:
tx.originanddelegateCalloverloads in a later PR. The TX origin is exposed fromevm.Origin, but we need anevmhandle. And thedelegateCallflag requires us to pokescopeContext.Contract.self, which is currently unexposed inmedusa-geth. Relevant TODO comments are left as placeholders.