Conversation
|
This is still WIP
On a separate note, |
|
Hey @0xZRA sorry for the delay - will provide feedback today :) |
|
|
||
| require(deployedHash == referenceHash, "Retrieved bytecode doesn't match reference"); | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
make sure to add a newline here
|
@0xZRA before reviewing the PR i want to make sure we satisfy the issue. It is possible that the creator of the issue does in fact want the versioning support as well. If they do then you may need to add support for that as well. |
@anishnaik For sure, makes sense to me |
anishnaik
left a comment
There was a problem hiding this comment.
No major feedback outside of the optimization I mentioned :) Appreciate all the work!
I should be able to wrap this up within next few days |
|
@anishnaik I'm concerned that without being able to run the tests locally, there's no way for me to confirm if the proposed code is functioning correctly. Other than that, the changes are ready for your review |
|
Hey @0xZRA I'm going to push the patch for the bug in the master branch right now. Then you will be able to pull it down and make sure all the tests pass locally. Btw you should still be able to specifically test your unit test instead of running the whole test suite. That should help you validate the expected behavior. |
|
Btw I know why your test is failing - your test contract's name has to be |
Thank you, it worked! |
|
@0xZRA can you fix the compilation issues in the test? |
This PR will close #576