Conversation
Member
Author
|
This PR is now ready for review. It should be merged alongside crytic/medusa-geth#2 (updated CONTRIBUTING.md in Keep in mind, this PR will be a bit painful in that it will change all module import paths, so existing PRs will probably have to replace any new/changed import paths to point at the new module path. |
… regardless of order of events.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #205 (and addresses a bullet point in #218).
A primer on the current/previous state:
go.modallows you to specify areplacesdirective to redirect one package path to another.medusaused this to redirectgithub.com/ethereum/go-ethereumpaths togithub.com/crytic/medusa-geth.medusa-gethupdates just involved forking and applying our patches on top, then re-linking medusa to the new version.replacesdirective only works on the top-level projects, so any attempt to usemedusaas a dependency will not include thereplacesdirective and will breakmedusa's ability to be imported. This same problem is also whygo installwill not work (asreplacesis not respected).TLDR: We were prone to golang/go#44840 .
This new PR updates this by:
medusa-geth.medusa-gethin themedusaproject.replacesdirective with a proper import togithub.com/crytic/medusa-geth.The implications are:
go-ethereumwill now have two changes to their process: (1) a refactor commit doing a replace-all of any instances ofgithub.com/ethereum/go-ethereumtogithub.com/crytic/medusa-gethshould be done after our patch set is applied and all is finalized, (2) the patch set we carry forward should not include the final refactoring commit (from step 1), as the imported files will likely change all the time.Outstanding TODOs on my end before I ask for a PR review:
medusa-gethto reflect this.Currently, you can test this with
go install -v github.com/crytic/medusa@refactormod. Once it is merged,go install -v github.com/crytic/medusa@latestshould work