feat: Reversion metrics#466

Merged

anishnaik merged 34 commits intomasterfrom

dev/reversion-metrics

Mar 26, 2025

Contributor

bsamuels453 commented Aug 28, 2024 •

edited by anishnaik

Loading

Closes #431

bsamuels453 added 4 commits

August 27, 2024 08:34


          mvp reversion stats

5b69b2c


          convert to using OnPendingBlockCommittedEvent

686daa9


          add reversion metrics config

14b4d00


          refactor

e5fafe1

bsamuels453 requested review from 0xalpharush, Xenomega and anishnaik as code owners

August 28, 2024 01:19

bsamuels453 added 6 commits

August 28, 2024 12:03


          update reversion report

b6411ea


          fix tests

cfb125a


          add statsig report to individual functions

553a6ef


          lint and documentation

4cadff2


          disable writing reversion report

c68f442


          fix goroutine leak

79ccf38

bsamuels453 changed the title ~~[Draft] Reversion metrics~~ feat: Reversion metrics

0xalpharush reviewed

View reviewed changes

fuzzing/config/config_defaults.go Outdated Show resolved Hide resolved

0xalpharush reviewed

View reviewed changes

fuzzing/fuzzer.go Outdated Show resolved Hide resolved

0xalpharush reviewed

View reviewed changes

fuzzing/fuzzer.go Outdated Show resolved Hide resolved

0xalpharush reviewed

View reviewed changes

fuzzing/reversion/revert_report.go Outdated Show resolved Hide resolved

0xalpharush reviewed

View reviewed changes

fuzzing/reversion/revert_report.go Outdated Show resolved Hide resolved

0xalpharush reviewed

View reviewed changes

fuzzing/reversion/reversion_statistics.go Outdated Show resolved Hide resolved

0xalpharush reviewed

View reviewed changes

fuzzing/reversion/reversion_statistics.go Outdated Show resolved Hide resolved

0xalpharush reviewed

View reviewed changes

fuzzing/fuzzer.go Outdated Show resolved Hide resolved

Contributor

0xalpharush commented Aug 29, 2024 •

edited

Loading

Could we pick one phrase like "Revert Statistics" and use it consistently right now there's three or four ways and it'll be easier to search in the codebase for if we use the same terms?

bsamuels453 and others added 5 commits

August 29, 2024 10:01


          remove unused changes

8d4c272


          disable reversion measurement by default

6cf911d


          add other pr recs

3db1d14


          more changes

568e40d


          Update fuzzing/fuzzer.go

216a6a6

Co-authored-by: alpharush <[email protected]>

Contributor Author

bsamuels453 commented Aug 29, 2024

Could we pick one phrase like "Revert Statistics" and use it consistently right now there's three or four ways and it'll be easier to search in the codebase for if we use the same terms?

agree, I've refactored this to call the component the "reversion reporter"


          renaming and fix lint

d1a9db6

bsamuels453 added 2 commits

August 29, 2024 11:29


          forgot to re-gen configs

4a4b7d6


          last two changes

3d7e212

bsamuels453 requested a review from 0xalpharush

August 29, 2024 18:47

bsamuels453 added 2 commits

August 29, 2024 12:49


          remove debug code

18e4696


          fix dumb typo

65786b7

bsamuels453 changed the title ~~feat: Reversion metrics~~ [Draft] feat: Reversion metrics

bsamuels453 changed the title ~~[Draft] feat: Reversion metrics~~ feat: Reversion metrics

Contributor Author

bsamuels453 commented Sep 6, 2024

@0xalpharush I'm satisfied with how the feature is working; this PR is ready for final review.

bsamuels453 and others added 14 commits

September 9, 2024 11:28


          Merge branch 'master' into dev/reversion-metrics

d243328


          Merge remote-tracking branch 'origin' into dev/reversion-metrics

0ed8e74

# Conflicts:
#	fuzzing/config/gen_fuzzing_config.go
#	fuzzing/fuzzer.go
#	fuzzing/fuzzer_worker.go


          temporary commit

1de97c6


          Merge remote-tracking branch 'origin' into dev/reversion-metrics

033a8c8

# Conflicts:
#	fuzzing/fuzzer.go


          update revert reporter

6c08463


          temporary commit

9129c73


          finalized logic and started working on report

0f55681


          Merge remote-tracking branch 'origin' into dev/reversion-metrics

ba9dc6b

# Conflicts:
#	fuzzing/config/config_defaults.go
#	fuzzing/config/gen_fuzzing_config.go
#	fuzzing/fuzzer.go
#	fuzzing/fuzzer_test.go
#	go.mod


          minimize diff

22d0a6a


          fix compilation issue and small bugs

1aae5fc


          remove test for revert reporter

885f911


          fix lints

1e2ee52


          decouple adding custom errors and improve documentation

ea72a40


          fix mds

1734f2e

anishnaik approved these changes

View reviewed changes

anishnaik merged commit c7b8aeb into master

12 checks passed

anishnaik deleted the dev/reversion-metrics branch

March 26, 2025 15:33

anishnaik mentioned this pull request

Add function calls success rate to metric information #278

Closed

BrewTestBot mentioned this pull request

medusa 1.2.0 Homebrew/homebrew-core#216873

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet