fix: use read-only lock for event callbacks#388
Merged
Conversation
dguido
approved these changes
Jan 20, 2026
Member
dguido
left a comment
dguido
left a comment
There was a problem hiding this comment.
LGTM - This is a correct and valuable fix.
Assessment:
- ✅ Legitimate performance improvement using RWMutex for read-heavy event publishing
- ✅ Maintains synchronization guarantees - no new race conditions
- ✅ Removes serialization bottleneck in parallel worker event publishing
- ✅ Matches existing RWMutex pattern used elsewhere in codebase (e.g., non_persistent_cache.go)
This allows all workers to publish events concurrently rather than waiting in line.
dguido
force-pushed
the
fix/use-rwmutex
branch
from
e8d0e76 to
31ec037
Compare
dguido
force-pushed
the
fix/use-rwmutex
branch
from
31ec037 to
0787cc2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.