Extend Foundry support testing#1512
Merged
gustavo-grieco merged 10 commits intocrytic:dev-improve-foundry-supportfrom Jan 13, 2026
Merged
Extend Foundry support testing#1512gustavo-grieco merged 10 commits intocrytic:dev-improve-foundry-supportfrom
gustavo-grieco merged 10 commits intocrytic:dev-improve-foundry-supportfrom
Conversation
BowTiedRadone
requested review from
arcz,
elopez and
gustavo-grieco
as code owners
Collaborator
|
Thanks a lot for extending this PR. We will need to test:
Besides that, we will need to ensure that the impact in the codebase is minimized. I think there are a few cases that functions that are already defined elsewhere such as isFailedAssertion. Additionally, use .yaml files instead of passing the config in the code. |
| seed: 1234 | ||
| cryticArgs: ["--solc-remaps", "forge-std/=foundry/forge-std/src/"] | ||
| symExec: true | ||
| symExecSMTSolver: z3 |
Collaborator
There was a problem hiding this comment.
We will probably use bitwuzla instead
src/test/Tests/FoundryTestGen.hs
Outdated
| testForgeCompilation = do | ||
| -- ============================================================================ | ||
| -- Test helpers | ||
| -- ============================================================================ |
Collaborator
There was a problem hiding this comment.
Please keep the document comments format consistent with the rest of our comments.
src/test/Tests/FoundryTestGen.hs
Outdated
| -- General utilities | ||
|
|
||
| -- | Run an IO action that requires forge, failing if forge is not found. | ||
| requireForge :: IO () -> IO () |
Collaborator
There was a problem hiding this comment.
Abstract these two in a single function using arguments. Move into a more general unit test code module.
src/test/Tests/FoundryTestGen.hs
Outdated
| -- Concrete Tests | ||
| -- ============================================================================ | ||
|
|
||
| -- | Verify generated test compiles with forge. |
Collaborator
There was a problem hiding this comment.
Actually, I don't think we need all this code. This tests are the same as normal echidna test, but the target is a foundry project, so they should work with the normal test infrastructure we already have. Check other examples.
Collaborator
|
I think two cases remains untested:
|
BowTiedRadone
changed the title
gustavo-grieco
merged commit e1f3265
into
crytic:dev-improve-foundry-support
1 check passed
gustavo-grieco
added a commit
that referenced
this pull request
Mar 13, 2026
* improved support for foundry tests * Extend Foundry support testing (#1512) * Fix lint failures * ci: bump python version to 3.10, clone submodules * some fixes when using foundry mode * Update hevm to `542986dea3bec4f5898731ff48877a7a21811bf4` * Fix bugs in Foundry test generation (#1516) * Fix fallback function bug in Foundry test generation * Fix null byte in argument bug in Foundry test generation * Remove unnecessary config file * Remove unused/redundant imports * Disable Slither in Foundry test gen tests * Conditionally run forge-std tests based on the solc version * Reduce unnecessary test grouping and improve failed assertion messages --------- Co-authored-by: Emilio López <[email protected]> * Update hevm to `41e6d1304411749ea8c816d131991663b5dca67a` * Fix linter and build errors (#1521) * improve foundry stateful invariant testing * fix * Fix foundry test generation linter hints and tests (#1522) * Foundry updates (#1525) * Rename dapptest to foundry and support foundry assertX in assertion mode * Rename basic foundry test contracts dir to `foundry-basic` * Add testing modes to `README` * fixes * fixes * Add support for Foundry assume (#1528) * flake: sync hevm version with stack.yaml * Clarify `optimization` test mode in `README` (#1529) * IS_TEST fix --------- Co-authored-by: Radu Bahmata <[email protected]> Co-authored-by: Emilio López <[email protected]> Co-authored-by: Emilio López <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes compilation errors in
checkAssertionsfor Foundry support and adds an end-to-end test for Foundry stateless bug reproduction.