Improve identification of CBOR bytecode metadata#1506
Merged
gustavo-grieco merged 2 commits intomasterfrom Mar 13, 2026
Merged
Conversation
Member
elopez
commented
Dec 27, 2025
elopez
commented
- pick the last prefix if several are present, to work in bytecode-in-bytecode scenarios (e.g., a contract that deploys other contracts)
- identify CBOR length and drop other trailing data (typically constructor arguments)
Collaborator
|
I think this will need some amount of testing, in particular, deploying factories. |
* pick the last prefix if several are present, to work in bytecode-in-bytecode scenarios (e.g., a contract that deploys other contracts) * identify CBOR length and drop other trailing data (typically constructor arguments)
In bytecode-in-bytecode scenarios (e.g. a contract deploying another), the child contract's CBOR prefix can appear in the middle of the parent bytecode. Previously we only tried the last prefix match and fell back to full bytecode if it was invalid. Now we try all matches from end to start and return the first one with a valid CBOR length.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.