Do not fetch if etherscan key is not available and support different chain ids#1492
Merged
gustavo-grieco merged 5 commits intomasterfrom Dec 15, 2025
Merged
Do not fetch if etherscan key is not available and support different chain ids#1492gustavo-grieco merged 5 commits intomasterfrom
gustavo-grieco merged 5 commits intomasterfrom
Conversation
elopez
reviewed
Dec 13, 2025
| Just dir -> do | ||
| -- coverage reports for external contracts, we only support | ||
| -- Ethereum Mainnet for now | ||
| when (env.chainId == Just 1) $ do |
Member
There was a problem hiding this comment.
I'm not sure we can allow other chains yet, as fetchContractSourceMap only supports eth mainnet
elopez
force-pushed
the
fixes-etherscan-fetching
branch
from
cd7f77c to
5fd1eed
Compare
datradito
pushed a commit
to datradito/echidna-mcp
that referenced
this pull request
Dec 29, 2025
…chain ids (crytic#1492) * do not fetch if etherscan key is not available and support different chain ids * etherscan: add support for source maps on other chains * etherscan: move cache away from Env * etherscan: remove extra & on URLs * onchain: remove dead code --------- Co-authored-by: Emilio López <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #1230 #1486