fix: ppAbiValue mapping in JSON.mapCall for SolCall#1445
Merged
elopez merged 1 commit intocrytic:masterfrom Sep 11, 2025
Merged
fix: ppAbiValue mapping in JSON.mapCall for SolCall#1445elopez merged 1 commit intocrytic:masterfrom
elopez merged 1 commit intocrytic:masterfrom
Conversation
VolodymyrBg
requested review from
arcz,
elopez and
gustavo-grieco
as code owners
elopez
approved these changes
Sep 11, 2025
Member
elopez
left a comment
elopez
left a comment
There was a problem hiding this comment.
good catch, thanks for the PR!
I feel the JSON output mode might be a bit abandoned, with these sorts of things going unnoticed 😅 do we know if anyone is using it @gustavo-grieco ?
datradito
pushed a commit
to datradito/echidna-mcp
that referenced
this pull request
Dec 29, 2025
fix: ppAbiValue mapping in JSON.mapCall for SolCall
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace incorrect applicative usage ppAbiValue <$> mempty <*> args with ppAbiValue mempty <$> args. The previous form attempted to fmap over mempty as a Functor, producing a type mismatch and not actually applying labels. The corrected code explicitly applies an empty label map to ppAbiValue and maps over the AbiValue list, aligning with how ppAbiValue is used elsewhere (e.g., Pretty.hs) and ensuring arguments encodes as [String] as intended.