Skip to content

docs: fix incorrect Docker volume mount command#1433

Merged
elopez merged 1 commit intocrytic:masterfrom
zkpepe:patch-1
Aug 28, 2025
Merged

docs: fix incorrect Docker volume mount command#1433
elopez merged 1 commit intocrytic:masterfrom
zkpepe:patch-1

Conversation

@zkpepe
Copy link
Copy Markdown
Contributor

@zkpepe zkpepe commented Aug 28, 2025

noticed that the provided Docker commands don’t work as written because pwd is treated as a literal directory name instead of being evaluated. this makes the examples unusable out of the box.

changed -v pwd:/src-v "$(pwd)":/src so that the current path is correctly mounted.

both affected commands are updated - now they run as expected without errors.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Aug 28, 2025

CLA assistant check
All committers have signed the CLA.

@elopez
Copy link
Copy Markdown
Member

elopez commented Aug 28, 2025

Hi @zkpepe ! What OS/shell were you seeing this behavior on? In my experience backticks should be equivalent to the $(...) syntax 🤔 https://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_06_03

@zkpepe
Copy link
Copy Markdown
Contributor Author

zkpepe commented Aug 28, 2025

elopez, I observed this behavior on macOS 14 / zsh. The issue occurs when the current path contains spaces, e.g., /Users/John Doe/.... Using $(pwd) with quotes ensures that the path is correctly expanded and handled by Docker, which backticks without quotes do not.

@elopez
Copy link
Copy Markdown
Member

elopez commented Aug 28, 2025

Ah, so it's a matter of word splitting rather than backticks not working. Sounds good then!

@elopez elopez merged commit a55c95d into crytic:master Aug 28, 2025
15 checks passed
@zkpepe zkpepe deleted the patch-1 branch August 28, 2025 16:51
datradito pushed a commit to datradito/echidna-mcp that referenced this pull request Dec 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants