Add values from tuple elements into the dictionary#1406
Merged
elopez merged 7 commits intocrytic:masterfrom Aug 7, 2025
Merged
Add values from tuple elements into the dictionary#1406elopez merged 7 commits intocrytic:masterfrom
elopez merged 7 commits intocrytic:masterfrom
Conversation
elopez
reviewed
Jul 29, 2025
Co-authored-by: Emilio López <[email protected]>
Co-authored-by: Emilio López <[email protected]>
elopez
reviewed
Jul 31, 2025
lib/Echidna/Campaign.hs
Outdated
| if isTuple type' | ||
| then Just $ Map.fromListWith Set.union | ||
| [ (abiValueType val, Set.singleton val) | ||
| | val <- V.toList $ getTupleVector abiValue |
Member
There was a problem hiding this comment.
should these be filtered so no cheatCode makes its way into the dictionary?
Collaborator
Author
There was a problem hiding this comment.
Let me fix that
Collaborator
Author
There was a problem hiding this comment.
Should we move the cheat code detection deeper into the dictionary handling to avoid duplication?
Collaborator
Author
There was a problem hiding this comment.
This is done, even at the cost of duplicating the logic a bit
elopez
approved these changes
Aug 7, 2025
datradito
pushed a commit
to datradito/echidna-mcp
that referenced
this pull request
Dec 29, 2025
* add values from tuple elements into the dictionary * added test * avoid adding cheatcode into dictionary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should allow echidna to solve this:
We need to add this into a test.