Complete Echidna refactor to remove the use of Hedgehog properties, simplify code and add missing features#133
Closed
gustavo-grieco wants to merge 45 commits intomasterfrom
Closed
Complete Echidna refactor to remove the use of Hedgehog properties, simplify code and add missing features#133gustavo-grieco wants to merge 45 commits intomasterfrom
gustavo-grieco wants to merge 45 commits intomasterfrom
Conversation
This was referenced Oct 3, 2018
…a into dev-no-hedgehog
Contributor
|
Superseded by #157 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a complete refactoring of the Echidna code to remove the use of Hedgehog properties, simplify code and include some missing features. It was started during the EthBerlin . This PR is not ready to be merged, it should be carefully reviewed before merging it. The main features of this refactoring are:
Some interesting side effects of this refactoring:
We also implemented some missing features:
Please not that Hedgehog is not removed because the value generation and resizing is certainly useful, but we should be able to delete the internal runner module.