Skip to content

Show trace on UnknownFailure#1283

Merged
gustavo-grieco merged 1 commit intomasterfrom
showTraceOnError
Jul 8, 2024
Merged

Show trace on UnknownFailure#1283
gustavo-grieco merged 1 commit intomasterfrom
showTraceOnError

Conversation

@samalws-tob
Copy link
Copy Markdown
Collaborator

@samalws-tob samalws-tob commented Jul 1, 2024

Partially resolves #938

@samalws-tob samalws-tob force-pushed the showTraceOnError branch 3 times, most recently from bf83858 to 9e49e6e Compare July 2, 2024 14:22
@samalws-tob samalws-tob marked this pull request as ready for review July 2, 2024 14:54
@gustavo-grieco
Copy link
Copy Markdown
Collaborator

Why this is partially resolving 938?

@samalws-tob
Copy link
Copy Markdown
Collaborator Author

Because it doesn't explicitly provide a trace message of "you used an unknown cheatcode vm.expectRevert, which echidna doesn't support" but you can figure out what the unknown cheatcode is from the stack trace

@gustavo-grieco
Copy link
Copy Markdown
Collaborator

This is good enough.

@gustavo-grieco gustavo-grieco merged commit bf14ea4 into master Jul 8, 2024
@gustavo-grieco gustavo-grieco deleted the showTraceOnError branch July 8, 2024 13:36
datradito pushed a commit to datradito/echidna-mcp that referenced this pull request Dec 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: more visibility for unsupported cheatcodes (BadCheatCode)

2 participants