fix: normalize windows path to handle solc >=0.8.8 filename lookup#554
fix: normalize windows path to handle solc >=0.8.8 filename lookup#5540xalpharush merged 2 commits intodevfrom
Conversation
|
Important Auto Review SkippedAuto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
4635aa0 to
8682260
Compare
The normalization of path added in solc 0.8.8 (argotorg/solidity#11545) was causing issues looking up the filename as the drive is no longer on the AST's
absolutePathbut was in the path we useThe zip archive test wasn't running in CI and the test file from #450 was missing so I've corrected that.