fix regression in legacy zip archive format#449
Closed
0xalpharush wants to merge 7 commits intodevfrom
Closed
Conversation
0xalpharush
commented
Jun 9, 2023
Comment on lines
292
to
-305
| if skip_filename: | ||
| filename = convert_filename( | ||
| file_path, | ||
| relative_to_short, | ||
| compilation_unit.crytic_compile, | ||
| working_dir=solc_working_dir, | ||
| ) | ||
| filename = compilation_unit.crytic_compile.filename_lookup(file_path) | ||
| else: | ||
| filename = convert_filename( | ||
| file_path, | ||
| relative_to_short, | ||
| compilation_unit.crytic_compile, | ||
| working_dir=solc_working_dir, | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
I don't know what purposed skip_filename serves. It seems like it hasn't done anything since 8eec142#diff-5919c9835671c24ce72c5fecf7f8dec4bfbc62baf8e06c70d227ffd013629e38L158-L174
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced by #436. It seems that this change will make slither's CI all green again (https://github.com/crytic/slither/actions/runs/5225290482). There were calls to
create_source_unitthat overwrote theastto{}after already creating the source unit. Instead of recreating it, it is now looked up using the filename.