[Breaking API Change] Use list instead of set for filenames and contracts_names; change filename ordering#436
Conversation
Contributor
Author
|
(cc @samalws-tob for visibility) |
Contributor
|
The reasons we need
Both of these apply to It seems like, in any case involving echidna, only one |
This was referenced Jun 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build on top of #432 + merge dev + fix pylint
One thing I am unsure is if
crytic_compile.filenamesshould return a list or a set. This is a merge of all the filenames from the different compilation units, so it can contain duplicate. Solutions:The set remove the order, however the order makes sense only at the compilation unit level, and not the CryticCompile level I think.
What do you all think?