[Breaking API Change] Use list instead of set for filenames and contracts_names; change filename ordering#432
Closed
samalws-tob wants to merge 1 commit intocrytic:devfrom
Closed
[Breaking API Change] Use list instead of set for filenames and contracts_names; change filename ordering#432samalws-tob wants to merge 1 commit intocrytic:devfrom
samalws-tob wants to merge 1 commit intocrytic:devfrom
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(See bolded for TODOs that I could use some advice on)
This PR:
filenamesandcontracts_names.filenamesis ordered in the same way astargets_json["sources"]. In waffle and embark, this results in new code. Otherwise it's just moving code around.platform/standard.pythat added filenames to the list.It fixes:
source_listbeing ordered differently than the source list outputted by the compiler, resulting in source maps being incorrect, resulting in echidna producing bad coverage reports.Testing:
targets_loaded["sources"]doesn't exist and my new code never gets called, resulting in filenames potentially having the wrong order.