Conversation
|
WalkthroughThis update enhances the GitHub Actions workflow and Homebrew release configuration, while also updating the README to reflect a command usage change. The changes primarily involve the use of environment variables and secrets for deployment keys and tokens, and the modification of the Homebrew formula source. Changes
Uplevel your code reviews with CodeRabbit ProCodeRabbit ProIf you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Files selected (2)
- .github/workflows/release.yml (2)
- .goreleaser.yml (2)
Files skipped from review due to trivial changes (1)
- .github/workflows/release.yml
Review comments generated (2)
- Review: 2
- LGTM: 0
Tips
Chat with 
CodeRabbit Bot (@coderabbitai)
- Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
- Invite the bot into a review comment chain by tagging
@coderabbitaiin a reply.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@coderabbitai: ignoreanywhere in the PR description to pause further reviews from the bot.
| # ensures mod timestamp to be the commit timestamp | ||
| mod_timestamp: "{{ .CommitTimestamp }}" | ||
|
|
||
| source: | ||
| enabled: true | ||
| rlcp: true | ||
| archives: | ||
| - format: tar.gz | ||
| # this name template makes the OS and Arch compatible with the results of uname. |
There was a problem hiding this comment.
The removal of the source section and its replacement with the archives section seems to be a significant change. However, without more context about how this configuration is used in your project, it's hard to say if this will cause any issues. Please ensure that this change aligns with your project's requirements for packaging and distribution.
- source:
- enabled: true
- rlcp: true
+ archives:
+ - format: tar.gz
+ # this name template makes the OS and Arch compatible with the results of uname.There was a problem hiding this comment.
fixes goreleaser deprecation warnings
There was a problem hiding this comment.
@oldsj Thank you for the clarification. If these changes are intended to address deprecation warnings from goreleaser, then it makes sense to update the configuration as you have done. Please ensure to test the release process thoroughly after these changes to confirm that everything still works as expected.
| - repository: | ||
| owner: trailofbits | ||
| name: homebrew-tools | ||
| token: "{{ .Env.GITHUB_TOKEN }}" | ||
| git: | ||
| url: [email protected]:trailofbits/homebrew-tools.git | ||
| private_key: "{{ .Env.PRIVATE_KEY }}" |
There was a problem hiding this comment.
The changes made here seem to be correct as per the new Homebrew tap syntax. The repository field replaces the old tap field and the git field is used to specify the git URL and private key. Just make sure that the PRIVATE_KEY environment variable is properly set in your CI/CD pipeline.
- - tap:
- owner: trailofbits
- name: homebrew-tools
- token: "{{ .Env.GITHUB_TOKEN }}"
+ - repository:
+ owner: trailofbits
+ name: homebrew-tools
+ git:
+ url: [email protected]:trailofbits/homebrew-tools.git
+ private_key: "{{ .Env.PRIVATE_KEY }}"
There was a problem hiding this comment.
Files selected (1)
- README.md (1)
Files skipped from review due to trivial changes (1)
- README.md
Review comments generated (0)
- Review: 0
- LGTM: 0
Tips
Chat with CodeRabbit Bot (@coderabbitai)
- Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
- Invite the bot into a review comment chain by tagging
@coderabbitaiin a reply.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@coderabbitai: ignoreanywhere in the PR description to pause further reviews from the bot.
1 participant
Fixes the homebrew tap publish step of the release.
Once merged and a new release is created, the
trailofbits/toolstap will be automatically updated.I removed the
RELEASE_TOKENsecret and replaced its use with the defaultGITHUB_TOKENsince that should be able to make a release, and we won't need to manage a personal token.HOMEBREW_TOOLS_DEPLOY_KEYis an SSH deploy key configured athttps://github.com/trailofbits/homebrew-tools/settings/keys
Summary by CodeRabbit
HOMEBREW_TOOLS_DEPLOY_KEYsecret forPRIVATE_KEYenvironment variable andGITHUB_TOKENsecret forGITHUB_TOKENenvironment variable.sourcesection withrepositorysection, specifying the owner, name, git URL, and private key for the Homebrew repository. This change alters the source of the Homebrew formula.cloudexec launch inittocloudexec init.