Fix BLAKE3 multi-chunk finalisation and wide hashing - #69
Merged
Conversation
Store parent chaining values in little-endian order and zero-pad partial final blocks. Adjust the SSE4.1, AVX2 and AVX512 paths to leave the final chunk in the chunk state, avoiding CV stack underflow for exact power-of-two chunk counts. Add official multi-chunk vectors and single-shot coverage for the affected lengths, including keyed hashing. Refs: #65
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the s390x BLAKE3 failures reported in #65 and two related defects found in the same finalisation path.
Update()calls. For exact power-of-two chunk counts, finalisation then underflowed the CV stack index.Adds the official 1025, 2049, 3073 and 4097-byte vectors, plus single-shot coverage for the wide paths and keyed hashing.
Closes #65.