Reject zero PBKDF iterations without a positive time budget - #59
Merged
Conversation
PBKDF1, PBKDF2, and the PKCS #12 KDF silently treated zero iterations as one when no positive time budget was supplied. Throw `InvalidArgument` instead while preserving the timed zero-iteration path. Add rejection, NaN, timed-mode, and RFC 7914 PBKDF2 tests. Reported upstream as weidai11/cryptopp issue 1366.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported upstream as weidai11/cryptopp#1366.
PBKDF1, PBKDF2, and the PKCS #12 KDF silently treated zero iterations as one when no positive time budget was supplied.
Reject that input with
InvalidArgumentwhile preserving the existing timed mode where zero iterations are paired with a positive time budget.Add rejection tests for all three KDFs, NaN handling, timed-mode controls, output-buffer preservation, and PBKDF2-HMAC-SHA256 vectors from RFC 7914.