Switch pkgconfig and cmake files to cmake libdir - #47
Merged
Conversation
Signed-off-by: Nicolas Chauvet <[email protected]>
Signed-off-by: Nicolas Chauvet <[email protected]>
Collaborator
|
Thanks, this is the right change. The exported CMake targets and generated CI is green on the head commit. I’ll squash on merge so the test updates land with the install-path change. You’re also right about the pkg-config name. Renaming |
This was referenced Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As cryptopp is a binary library, theses files should be distributed under a binary specific directory.
Side note: any reason to break compatibility with pkgconfig ? previous files where libcryptopp.pc and was renamed to cryptopp-modern.pc breaking compatibility ? (so it requires to change all underlying application in order to support pkgconfig for no reason).