Fix MSVC MASM object paths under CMake - #45
Merged
Conversation
Place MASM objects directly under $(IntDir) for Visual Studio generators instead of relying on source-tree object paths that ml64 may fail to create. Also tighten the ARM target check so ARM builds do not enter the MASM path by mistake.
Remove ASM from `project()` and enable it only for non-MSVC ARM builds. The x86 and x64 assembly path continues to use ASM_MASM.
Coralesoft
force-pushed
the
fix/msvc-masm-object-path
branch
from
July 13, 2026 12:42
0f1c137 to
554ca38
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #43. MASM can fail under the Visual Studio generator when
ml64is given a/Fopath under a source-tree subdirectory such assrc/random.-DCRYPTOPP_DISABLE_ASM=ONremains the workaround for affected builds.What changed
$(IntDir)usingObjectFileName.rdrand.asm-only/Fooverride.VS 2026 could not be reproduced locally, so the reporter will confirm that toolchain. CI covers the existing VS 2022 ASM path.
Closes #43