Remove BLAKE3 NEON single-block compress path - #30
Merged
Conversation
BLAKE3_Compress_NEON provides a fork-local single-block NEON compress path. The BLAKE3 reference uses the portable path for this case. ValidateBLAKE3 exposed failures against the official BLAKE3 KATs on macOS aarch64 runners. The same tests pass on the x86 SSE4.1 path, so remove the NEON-specific dispatch. aarch64 builds now use the portable `compress_internal` path from `BLAKE3::Compress`.
`ValidateBLAKE3()` can be run via `cryptest v 88`, but is not included in `ValidateAll()`. The default `cryptest v` run used by CI therefore misses the BLAKE3 KATs. Add it after the BLAKE2b validation so BLAKE3 runs with the other hash tests.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BLAKE3_Compress_NEONis a fork-local single-block NEON path. The BLAKE3 reference uses the portable path for this case.When
ValidateBLAKE3()was added to the defaultcryptest vrun, macOS aarch64 CI exposed failures against the official BLAKE3 KATs. This PR removes that NEON-specific path and re-adds the validation coverage.Changes:
BLAKE3::Compressblake3_simd.cppcompress_internalpathValidateBLAKE3()toValidateAll()Verification
Host build passes cleanly.
cryptest v 88passes the BLAKE3 KATs on the SSE4.1 path.cryptest vnow includes BLAKE3 validation and passes.macOS Apple Silicon CI covers the aarch64 portable fallback.
Refs: #27