Skip to content

fix for libfuse 3.17.1#88

Merged
infeo merged 2 commits intocryptomator:developfrom
nycex:develop
Apr 10, 2025
Merged

fix for libfuse 3.17.1#88
infeo merged 2 commits intocryptomator:developfrom
nycex:develop

Conversation

@nycex
Copy link
Copy Markdown
Contributor

@nycex nycex commented Apr 5, 2025 •
edited
Loading

essentially the same as cryptomator/cryptomator@40d632a
Fixes #87

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 5, 2025 •
edited
Loading

Walkthrough

The changes modify the project’s pom.xml file by updating the version of the fuse-nio dependency from 5.0.2 to 5.0.5. No other dependencies were modified or removed, and the overall structure of the properties section remains unchanged.

Assessment against linked issues

Objective Addressed Explanation
Update dependencies to resolve issues with mounting vaults (87) ✅
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d76b855 and 96485f7.

📒 Files selected for processing (1)
  • pom.xml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • pom.xml
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Apr 5, 2025
View reviewed changes
Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
pom.xml (1)

81-86: Temporary jfuse Dependency Addition and Version Consistency

The new dependency on jfuse (groupId: org.cryptomator, version 0.7.2) is clearly marked as a temporary measure via the inline TODO comment. To improve maintainability, consider defining a version property (e.g., <jfuse.version>0.7.2</jfuse.version>) in the <properties> section, which aligns with how other dependency versions are managed. Additionally, please ensure there is a corresponding issue or reminder in your project tracker to remove this dependency once fuse-nio-adapter is updated.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dec744e and d76b855.

📒 Files selected for processing (1)
  • pom.xml (1 hunks)

@overheadhunter
Copy link
Copy Markdown
Member

overheadhunter commented Apr 5, 2025

the fix needs another fix. We need to sort this out first. But then this change is welcome in the cli project as well.

@SailReal
Copy link
Copy Markdown
Member

SailReal commented Apr 9, 2025

@nycex This is the mentioned fix cryptomator/cryptomator@55d2178, can you please apply it here as well?

@nycex
Copy link
Copy Markdown
Contributor Author

nycex commented Apr 9, 2025

This now uses the same fix (version upgrade of fuse-nio as the main cryptomator repo).

@infeo infeo self-assigned this Apr 10, 2025
@infeo infeo added this to the 0.6.2 milestone Apr 10, 2025
@infeo infeo merged commit 166e30a into cryptomator:develop Apr 10, 2025
2 checks passed
@infeo
Copy link
Copy Markdown
Member

infeo commented Apr 10, 2025

@nycex Thanks for providing the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees

@infeo infeo

Labels

None yet

Projects

None yet

Milestone

0.6.2

Development

Successfully merging this pull request may close these issues.

Linux: unable to mount vaults with libfuse 3.17.1

4 participants

@nycex @overheadhunter @SailReal @infeo