[Cleanup] clang compiler warnings in coinSpend and publicCoinSpend fixed.

furszy · furszy · commit f912182d27e1 · 2019-06-09T22:24:13.000+02:00
diff --git a/src/libzerocoin/CoinSpend.cpp b/src/libzerocoin/CoinSpend.cpp
@@ -18,14 +18,15 @@
 namespace libzerocoin
 {
     CoinSpend::CoinSpend(const ZerocoinParams* paramsCoin, const ZerocoinParams* paramsAcc, const PrivateCoin& coin, Accumulator& a, const uint32_t& checksum,
-                     const AccumulatorWitness& witness, const uint256& ptxHash, const SpendType& spendType) : accChecksum(checksum),
-                                                                                  ptxHash(ptxHash),
+                     const AccumulatorWitness& witness, const uint256& ptxHash, const SpendType& spendType) :
                                                                                   coinSerialNumber((coin.getSerialNumber())),
+                                                                                  spendType(spendType),
+                                                                                  ptxHash(ptxHash),
+                                                                                  accChecksum(checksum),
                                                                                   accumulatorPoK(&paramsAcc->accumulatorParams),
                                                                                   serialNumberSoK(paramsCoin),
                                                                                   commitmentPoK(&paramsCoin->serialNumberSoKCommitmentGroup,
-                                                                                                &paramsAcc->accumulatorParams.accumulatorPoKCommitmentGroup),
-                                                                                  spendType(spendType)
+                                                                                                &paramsAcc->accumulatorParams.accumulatorPoKCommitmentGroup)
 {
     denomination = coin.getPublicCoin().getDenomination();
     version = coin.getVersion();
diff --git a/src/libzerocoin/CoinSpend.h b/src/libzerocoin/CoinSpend.h
@@ -89,6 +89,9 @@ class CoinSpend
     CoinSpend(const ZerocoinParams* paramsCoin, const ZerocoinParams* paramsAcc, const PrivateCoin& coin, Accumulator& a, const uint32_t& checksum,
               const AccumulatorWitness& witness, const uint256& ptxHash, const SpendType& spendType);
 
+
+    virtual ~CoinSpend(){};
+
     /** Returns the serial number of the coin spend by this proof.
 	 *
 	 * @return the coin's serial number
diff --git a/src/zpiv/zpivmodule.h b/src/zpiv/zpivmodule.h
@@ -35,6 +35,8 @@ class PublicCoinSpend : public libzerocoin::CoinSpend{
         this->version = COIN_SPEND_PUBLIC_SPEND_VERSION;
     };
 
+    ~PublicCoinSpend(){};
+
     template <typename Stream>
     PublicCoinSpend(
             libzerocoin::ZerocoinParams* params,

Original file line number	Diff line number	Diff line change
`@@ -89,6 +89,9 @@ class CoinSpend`
`89`	`89`	`CoinSpend(const ZerocoinParams* paramsCoin, const ZerocoinParams* paramsAcc, const PrivateCoin& coin, Accumulator& a, const uint32_t& checksum,`
`90`	`90`	`const AccumulatorWitness& witness, const uint256& ptxHash, const SpendType& spendType);`
`91`	`91`
	`92`	`+`
	`93`	`+ virtual ~CoinSpend(){};`
	`94`	`+`
`92`	`95`	`/** Returns the serial number of the coin spend by this proof.`
`93`	`96`	`*`
`94`	`97`	`* @return the coin's serial number`