Add support for Russian alphabet #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Member
|
Thank you for your pull request! Checking back on the Russian spelling alphabet & Фонетический алфавит some words are not spelled like they are in the official version: 'Анна' instead of 'А́нна', 'Борис' instead of 'Бори́с' and 'Василий' instead of 'Васи́лий' to just name a few. Is there a reasoning behind this? In general I'd like to make sure we stick close to the official or original version of a translation method. If this is a variant, it should be labeled as such. |
Contributor
Author
|
@ffraenz those accent marks are just word stress signs and they are completely optional. In order to support official versions, I will make a few more changes |
It is 'char' in encode mode It is 'word' in decode mode
This supports the case when one letter replacement is a substring of the other
Contributor
Author
|
Fixes #63 |
This was referenced Oct 12, 2019
Closed
ffraenz
approved these changes
Oct 20, 2019
Member
|
Thank you for the clarification! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the phonetic translation for the Russian alphabet as I want it to be included in your awesome website to help other people to spell Russian words over the phone.