Skip to content

BlockCipher Encoder with initial AES support #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ffraenz merged 14 commits into from
Oct 24, 2018
Merged

BlockCipher Encoder with initial AES support #31

ffraenz merged 14 commits into from
Oct 24, 2018

Conversation

@cryptographix
Copy link
Contributor

@cryptographix cryptographix commented Oct 20, 2018

Fixed base64 extracts from JSON (ByteSetting)

Added BlockCipher Encoder with support for AES-128/192/256 support (ECB, CBC, CTR modes).

100% pass for node tests.
As usual, webCrypto has variable support for modes and key-sized (grrrr). May need monkey-patching support for different combinations, but as at some point I intend to add DES as an algorithm, for which webCrypto has no support anyway .. this should/will be automatic

@cryptographix cryptographix reopened this Oct 20, 2018
ffraenz
ffraenz requested changes Oct 21, 2018
View reviewed changes
Copy link
Member

@ffraenz ffraenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing! This will be a nice addition to the modern cryptography section. I left a few comments that should be addressed before merging. Just let me know if you need anything.

@ffraenz
Copy link
Member

ffraenz commented Oct 22, 2018

I've made some changes. Would you allow to me to push them into your PR?

I am getting different results for AES-128-CBC and AES-256-CBC in the browser compared to the test node vectors. Do you know why?

I would disable AES-192 for now. I want to keep dependencies very low as long as there is no source splitting implemented in this project. I hope we soon can pull in well tested and independent libraries via Web Assembly.

@cryptographix
Copy link
Contributor Author

cryptographix commented Oct 23, 2018

Please do push them into the PR.
I'll check out the differing results .. I'll get back to you.

@ffraenz
Copy link
Member

ffraenz commented Oct 23, 2018 •
edited
Loading

I pushed my changes to the issue/31 branch. They add initial key and IV size restrictions, fix the layout when there is no padding field and reduce unnecessary code.

@ffraenz ffraenz changed the base branch from master to dev October 24, 2018 16:39
@ffraenz ffraenz merged commit b5cd343 into cryptii:dev Oct 24, 2018
@ffraenz
Copy link
Member

ffraenz commented Oct 24, 2018

Thank you for contributing!

@cryptographix
Copy link
Contributor Author

cryptographix commented Oct 24, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ffraenz ffraenz ffraenz approved these changes

Assignees

No one assigned

Labels

feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cryptographix @ffraenz