Skip to content

Fix validation errors for image transfers.#93

Merged
crud89 merged 4 commits intomainfrom
vk-texture-transfer-fix
Mar 29, 2023
Merged

Fix validation errors for image transfers.#93
crud89 merged 4 commits intomainfrom
vk-texture-transfer-fix

Conversation

@crud89
Copy link
Copy Markdown
Owner

@crud89 crud89 commented Mar 29, 2023

Describe the pull request

Transfers that involved textures required explicit barriers in order to work, which caused the textures sample to issue validation errors. This PR introduces implicit transitions before copying, effectively fixing those issues. Note, however, that an explicit barrier after copying is still required.

This PR also enables sampler anisotropy for the Vulkan backend.

@crud89 crud89 added Priority: Medium A issue with normal priority. Bug 🐞 Something isn't working. Type: Requirement Vulkan πŸŒ‹ The issue involves the Vulkan backend. labels Mar 29, 2023
@crud89 crud89 added this to the Alpha #04 milestone Mar 29, 2023
@crud89 crud89 self-assigned this Mar 29, 2023
@crud89 crud89 marked this pull request as ready for review March 29, 2023 13:34
@crud89 crud89 merged commit 4e01c2a into main Mar 29, 2023
@crud89 crud89 deleted the vk-texture-transfer-fix branch March 29, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug 🐞 Something isn't working. Priority: Medium A issue with normal priority. Vulkan πŸŒ‹ The issue involves the Vulkan backend.

Projects

Status: v0.4.1

Development

Successfully merging this pull request may close these issues.

1 participant