Shared temporary ownership for command buffers and resources.#89
Merged
Shared temporary ownership for command buffers and resources.#89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
This PR allows command queues to take temporary shared ownership over one or more command buffers during submit. Ownership is held until the submitted fence value has been surpassed. It is released during
waitFor. This allows for temporary command buffers to stay alive, until they are executed. It is no longer necessary to manually manage and release such command buffers.Similarly, transfer operations inside command buffers can take a temporary shared ownership over resources. If a command queue waits for a fence, all completed command buffers are asked to release the references shared this way. This is useful to implement "fire-and-forget" buffers, for example for staging purposes.
To make this possible, all command buffers are stored in shared pointers by default and the command queue only accepts shared command buffer pointers on submission. For resources, shared ownership can be enabled using
asShared.